-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: GitLab MR Preview with docker-compose fails (depends on unknown service) #2005
Comments
I run into the same issue when running preview deployments. On the main deployment flow the process works fine.
(reduced) docker-compose content from coolify UI: services:
backend:
depends_on:
- database
labels:
- coolify.version=4.0.0-beta.278
- coolify.name=backend-f2sg4o0-172530544062
- coolify.pullRequestId=0
container_name: backend-f2sg4o0-172530544062
database:
image: 'mariadb:11.3'
labels:
- coolify.version=4.0.0-beta.278
- coolify.name=database-f2sg4o0-172530544894
- coolify.pullRequestId=0
container_name: database-f2sg4o0-172530544894 |
I dug into source code of coolify and found that the job creates a Logging into server I found the file and the generated docker-compose file for the PR looks like the following (based on my previous comment): services:
backend-pr-117:
depends_on:
- database
labels:
- coolify.version=4.0.0-beta.278
- coolify.name=backend-f2sg4o0-pr-117
- coolify.pullRequestId=117
container_name: backend-f2sg4o0-pr-117
database-pr-117:
image: 'mariadb:11.3'
labels:
- coolify.version=4.0.0-beta.278
- coolify.name=database-f2sg4o0-pr-117
- coolify.pullRequestId=117
container_name: database-f2sg4o0-pr-117 So the service name is getting updated correctly, but the |
Description
When I create a merge request to get a preview app, it fails and tells me that my service is unknown.
I think the issue is that coolify renames the services in its custom docker-compose.yaml and does not rename the fields in "depends_on" or "links". I was not able to reproduce this error when copying the commands shown in the debug logs.
Minimal Reproduction (if possible, example repository)
Use the following docker-compose file:
And, after configuring the preview apps in coolify and the needed webhook in GitLab, create a merge request.
Exception or Error
Version
v4.0.0-beta.258
The text was updated successfully, but these errors were encountered: