Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when logging actions that receive non-serializable params #19

Open
rafaelrollup opened this issue Dec 8, 2023 · 1 comment

Comments

@rafaelrollup
Copy link

rafaelrollup commented Dec 8, 2023

In MST, we're able to store non-serializable objects in volatile fields. When using connectReduxDevtools, if we create an action to set such field, an error will be thrown because somewhere in code it tries to log the action arguments. For now I've simply disabled logArgsNearMe, but it would be nice to have this logging functionality for other actions whose args are indeed serializable.

Maybe we can do some sort of check? If it's serializable, then log it, if not simply skip it.

@coolsoftwaretyler
Copy link
Owner

Hey @rafaelrollup - thanks for submitting the issue.

Are you interested in submitting a PR to this effect? If so, I'd be happy to review and merge when you get to it.

If you're not interested in that, would you mind writing a reproducible example so other folks can be clear about the problem?

Thanks either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants