Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Upgrade copilot-version #360

Open
eval-exec opened this issue Jan 16, 2025 · 4 comments
Open

Request: Upgrade copilot-version #360

eval-exec opened this issue Jan 16, 2025 · 4 comments

Comments

@eval-exec
Copy link

eval-exec commented Jan 16, 2025

Latst copilot-version is 1.41.0,
But this copilot.el's copilot-version is 1.27.0

(defcustom copilot-version "1.27.0"
  "Copilot version.

The default value is the preferred version and ensures functionality.
You may adjust this variable at your own risk."
  :type 'string
  :group 'copilot)

Suggest upgrade copilot-version:

@eval-exec eval-exec changed the title Upgrade copilot-version Request: Upgrade copilot-version Jan 16, 2025
@kiennq
Copy link
Contributor

kiennq commented Feb 16, 2025

The #363 should also support to upgrade the copilot-version to the latest one from the official Github copilot LSP as well

@eval-exec
Copy link
Author

The #363 should also support to upgrade the copilot-version to the latest one from the official Github copilot LSP as well

Great! Thank you!

@rnadler
Copy link

rnadler commented Feb 17, 2025

Since the #363 update, getting this warning:

Warning (emacs): This package has been tested for Copilot server version nil but version 1.272.0 has been detected.
You can change the installed version with 'M-x copilot-reinstall-server' or remove this warning by changing the value of 'copilot-version'.
  • (setq! copilot-version "Latest") just changes the above warning message from nil to Latest.

  • (setq! copilot-version "1.272.0") of course resolves the warning message, but hard-coding the version is not a desired solution.

Thanks.

@kiennq
Copy link
Contributor

kiennq commented Feb 18, 2025

I would say that the latest version can contain breaking changes so they will always be untested until someone has done testing and made sure everything is still working fine. At that time, we can create a PR to update the copilot-version with the tested version.
Thus, I think the warning is appropriate. It's harmless though. Please update the copilot-version with the version you have tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants