Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our CSS needs attention. #242

Open
t4k opened this issue Jun 15, 2017 · 3 comments
Open

Our CSS needs attention. #242

t4k opened this issue Jun 15, 2017 · 3 comments

Comments

@t4k
Copy link
Contributor

t4k commented Jun 15, 2017

Pulled out of the conversation in #77 so this can be worked on bit by bit with an issue to point pull requests at.

It’s ad hoc, and not easily reusable or extensible. Part of this is due to the over-reliance on IDs serving as jquery hooks (which also tightly couples our HTML to our javascript to our CSS, making it difficult to improve any of the three). Another part is the abuse of the !important declaration, which breaks the C in CSS and is difficult to identify and fix.

@jcuenod
Copy link
Contributor

jcuenod commented Jun 16, 2017

Are you suggesting rewriting the frontend? This seems like an issue that can't be solved without a pretty significant overhaul...

@jsavell
Copy link
Contributor

jsavell commented Jun 16, 2017

It could be addressed piece by piece in scoped PRs.

Here's a refactor of the Queue functionality I did awhile back:

https://github.com/Coral-erm/Coral/pull/143/files

Looking at the changes to style.css, it's just an incremental improvement on a small section of the code, but the css file shrank by 45 lines.

Each incremental improvement will make the code easier to maintain and simplify any potential future front end rewrites.

@t4k
Copy link
Contributor Author

t4k commented Jun 16, 2017

Yes, my plan was to do some work similar to that mentioned in the comment above: small chunks of changes that will improve things over time.

Having this issue active will let us make PRs associated with it so we can group any CSS changes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants