Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceAcquisition table not created #350

Closed
jeffnm opened this issue Jan 23, 2018 · 3 comments
Closed

ResourceAcquisition table not created #350

jeffnm opened this issue Jan 23, 2018 · 3 comments
Assignees
Labels
bug This is a bug (not an enhancement)

Comments

@jeffnm
Copy link
Contributor

jeffnm commented Jan 23, 2018

As I noticed when testing #334 the ResourceAcquisition table is not in the upgrade or install sql for the resources module, and it should be in both for 2.1 or the resource module can't display resources on the main screen. References to it seem to have been introduced in 801c751

@veggiematts could you make sure all the database changes that are needed to support that code are in the install.sql file and in an upgrade file? I can't find reference to that new table in the sql, and I don't know if any other database changes were expected as part of that feature.

@jeffnm jeffnm added the bug This is a bug (not an enhancement) label Jan 23, 2018
@jeffnm jeffnm added this to the Version 2.1.0 Beta milestone Jan 23, 2018
@veggiematts
Copy link
Contributor

@jeffnm the upgrade file is here: resources/install/protected/update_Orders.sql
I'm not sure what's the current state of the installer (ie: if this file will be automatically processed on upgrade), but I'll look into it.

Also, I wasn't sure if the install.sql file should be updated only once upon new version release or on each PR. If it's on each PR, I'll gladly add the missing SQL to install.sql. Please let me know.

@veggiematts
Copy link
Contributor

@jeffnm see #351 for the upgrade.
Let me know for a fresh install.

@jeffnm
Copy link
Contributor Author

jeffnm commented Jan 24, 2018

@veggiematts ah, thanks, I'm not sure why I didn't see that when I searched that directory. The file won't be automatically processed on an upgrade unless it's added to the resources/install/resources.php 2.1.0 case, but that's not a difficult change.

For the fresh install, sometimes that needs to be different SQL than the upgrade, so it is probably worth including that at the time of the PR as well, rather than asking the releaser to convert update SQL into install SQL.

#334 has upgrade cases for 2.1.0, so perhaps we can get that merged in before adding your /install/protected/2.1.0/002-350.sql file to the resources updater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug (not an enhancement)
Projects
None yet
Development

No branches or pull requests

2 participants