Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment count not updating to reflect rejected comments #2292

Closed
emilyyount opened this issue Apr 30, 2019 · 2 comments
Closed

Comment count not updating to reflect rejected comments #2292

emilyyount opened this issue Apr 30, 2019 · 2 comments

Comments

@emilyyount
Copy link

Do you want to request a feature or report a bug?

Report a bug

Intended outcome:

Update comment count after comments are rejected.

Actual outcome:

I visited this page and noticed it shows the comment count as "1" but there aren't any comments in the stream. The juxtaposition of comment count "1" and "There are no comments yet. Why don’t you write one?" makes it feel broken.

Screen Shot 2019-04-30 at 2 18 25 PM

How to reproduce the issue:

In your own test environment, find a story with comments already in the stream. Reject all of those comments. Check to see if the comment count matches the number of comments in the stream.

Version and environment

macOS Mojave Version 10.14.4
Chrome Version 73.0.3683.103
talk:4.8.3-onbuild

@wyattjoh
Copy link
Collaborator

wyattjoh commented May 1, 2019

Hi @emilyyount!

I tried to replicate your issue, but was unable to do so. Have you enabled any plugins that would affect the comment count, such as https://docs.coralproject.net/talk/plugin/talk-plugin-deep-reply-count?

We also perform some caching on the comment count data, if data was modified directly, or an error occurred, the count may not be updated. You can adjust the https://docs.coralproject.net/talk/advanced-configuration/#talk-cache-expiry-comment-count variable in order to get a better rollover of expired counts if that helps!

@emilyyount
Copy link
Author

Thank you. We haven't enabled any plugins that could affect the comment count. I think adjusting the cache expiry would do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants