Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Extract Link from text before cleaning #43

Open
ArmoredCavalry opened this issue Feb 18, 2025 · 2 comments
Open

[Feature] Extract Link from text before cleaning #43

ArmoredCavalry opened this issue Feb 18, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@ArmoredCavalry
Copy link
Contributor

One thing a lot of apps / sites do these days is prepend boiler plate or extra text before the actual link (when you click a share button).

Would be neat to have LinkCleaner detect / remove that text and then just process / output the clean link. Right now when I share such text to LC, it outputs blank instead (assuming it can't process the text and stops?)

@corbindavenport
Copy link
Owner

I remember looking into this a while ago but the example I was using stopped adding extra text, I think maybe it was Spotify? If you have some example sites/apps where I can replicate the behavior it should be a pretty easy fix.

@corbindavenport corbindavenport added the enhancement New feature or request label Feb 18, 2025
@ArmoredCavalry
Copy link
Contributor Author

ArmoredCavalry commented Feb 18, 2025

Sure! Not the best example, but it you go to an Amazon product page, hit share, and then scroll to "more" and click that should give you the full product name text + link at end.

I'm trying to remember other examples, but I only very occasionally run into the situation, sorry!

I got a chance to look through code and believe I found the proper place to add this (while still working with existing "Page Title" case). Submitted a PR here for you to take a look - #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants