Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP8 is missing in the result of createOffer() #415

Closed
oscarvadillog opened this issue Oct 23, 2019 · 7 comments
Closed

VP8 is missing in the result of createOffer() #415

oscarvadillog opened this issue Oct 23, 2019 · 7 comments
Assignees
Milestone

Comments

@oscarvadillog
Copy link

Expected behavior

That the VP8 codec be included in the SDP.

Observed behavior

VP8 is missing in the result of createOffer(). The sdp will only contain H264.
I manually manipulated the SDP to include VP8 instead of H264 but it didn't work. I watched several streams and the video elements blink :(

Steps to reproduce the problem

Simple test:

const pc = new RTCPeerConnection(null);
pc.createOffer({
  offerToReceiveAudio: true,
  offerToReceiveVideo: true,
}).then((v) => console.log(v.sdp))

Platform information

  • Cordova version: 8.1.2
  • Plugin version: 6.0.0 cd1a545
  • iOS version: 13.1.2
  • Xcode version: 11.1
@hthetiot
Copy link
Contributor

I have a fix, will be available today.

@hthetiot
Copy link
Contributor

hthetiot commented Oct 24, 2019

#416 Results in VP8, VP9 and H264 being available now.

const pc = new RTCPeerConnection(null);
pc.createOffer({
offerToReceiveAudio: true,
offerToReceiveVideo: true,
}).then((v) => console.log(v.sdp))

 ...
 a=rtpmap:96 VP9/90000
 ...
 a=rtpmap:98 H264/90000
 ...
 a=rtpmap:127 VP8/90000
 ...

@hthetiot
Copy link
Contributor

Thank you @oscarvadillog and @menelike for helping testing and for quick debug.

@hthetiot
Copy link
Contributor

I will wait for @oscarvadillog Testing and will release on master.

@hthetiot
Copy link
Contributor

I want to release #416 on master but we need more testing and possible exclude VP9 to avoid performance issues if needed.

@oscarvadillog
Copy link
Author

I've tested #416 and it's working well for me using VP8. Well done @hthetiot ❤️
I also think it would be nice to exclude VP9 to prevent performance issues.

@hthetiot
Copy link
Contributor

I moved H264 on preferred, I will try to see how to exclude VP9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants