Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black remote video on using twilio #541

Closed
3 tasks done
hthetiot opened this issue Jul 15, 2020 · 20 comments
Closed
3 tasks done

black remote video on using twilio #541

hthetiot opened this issue Jul 15, 2020 · 20 comments

Comments

@hthetiot
Copy link
Contributor

hthetiot commented Jul 15, 2020

Please read first!

Please use Public Google Group (mailing list) for general technical discussions and questions.

  • I have used Google with the error message or bug in association with the library and Cordova words to make sure the issue I'm reporting is only related to iOSRTC.
  • I have provided steps to reproduce (e.g. sample code or updated extra/renderer-and-libwebrtc-tests.js file).
  • I have provided third party library name and version, ios, Xcode and plugin version and adapter.js version if used.

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed, removing this checkbox will result in automatic closed issue.

Versions affected

  • Cordova version (e.g 7.1.0): 7
  • Plugin version (e.g 6.0.12): master
  • iOS version (e.g 10.2): 12
  • Xcode version (e.g 11.1 - 11A1027): 11A1027
  • WebRTC-adapter version (e.g. 7.4.0): 7.4.0
  • WebRTC Framework version (e.g. JSSip 3.1.2):

Description

Black video on remote participant unless using aee2b39

aee2b39b2ccebd3dc01019d7c8ebdf2bd4c90600.diff.txt

Steps to reproduce

Use sample Cordova twilio app.

Expected results

See remote participant video using master

Actual results

Black video on remote participant

@hthetiot hthetiot self-assigned this Jul 15, 2020
@hthetiot hthetiot added the bug label Jul 15, 2020
@hthetiot hthetiot added this to the 6.0.13 milestone Jul 15, 2020
@hthetiot
Copy link
Contributor Author

@sboudouk can you try 6.0.11 just curious.

@hthetiot
Copy link
Contributor Author

hthetiot commented Jul 15, 2020

@sboudouk I would also need if you can that you test the followinf version to try to understand what changes caused the issue

Notice that i suspect c04df62 to have broken compatilibity.

@hthetiot
Copy link
Contributor Author

I will not release 6.0.13 until this is solved for information :)

@sboudouk
Copy link

I will give it a shot then give you feedback there. Thanks for your work.

@hthetiot
Copy link
Contributor Author

Last 6.0.13 issue.

@hthetiot hthetiot reopened this Jul 17, 2020
@matijagrcic

This comment has been minimized.

@hthetiot

This comment has been minimized.

@matijagrcic
Copy link

Thanks for pointing that out, wanted to provide more info as it's related to the Twilio setup and remote video.

@hthetiot
Copy link
Contributor Author

If any Twillio user can assist and update the sample to help debug iosRTC with Twillio.
https://github.com/cordova-rtc/cordova-plugin-iosrtc-sample/blob/master/www/js/index-twilio.js

You can make a PR on Sample repository.

@sboudouk
Copy link

Ok then, there are my results:

Local Participant: iPhone 11 iOS 13.4.1
Remote Participant: Samsung Android 8.0.0
Twilio Room type: Group-small, and NOT p2p.

6.11:
Local Video: Local Camera successfully displayed and sent to remote. Displayed successfully on remote device.
Remote Video: No error, but can't receive, attach, or display remote video, not even a black screen.

df3105c:

Same results as 6.11.

c04df62:

Local Video: Local Camera successfully displayed and sent to remote. Displayed successfully on remote device.
Remote Video: No error, receive remote stream, but provides a blackscreen.

Here is a screenshot of console logs in participant.on('trackSubscribed') event.

First object is an instance of: RemoteTrack , and the second one is an instance of RemoteTrackPublication.

Capture d’écran 2020-07-27 à 00 33 26

cb0aefe:

Same results as c04df62.

I hope it will be helpful.

Thanks for your work, feel free to ask precisions.

@hthetiot
Copy link
Contributor Author

hthetiot commented Jul 28, 2020

can you try this ones @sboudouk

Example:

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#852024b6fc1d24837af29f8e05a23274eca0f167 --verbose

@sboudouk
Copy link

Local Participant: iPhone 11 iOS 13.4.1
Remote Participant: Samsung Android 8.0.0
Twilio Room type: Group-small, and NOT p2p.

b632a98:

LocalParticipant: LocalVideoTrack is displayeds successfully. Remote video track is black.
Remote Participant: RemoteParticipant track is received with success. (Audio + Video).

8de622a:

Exact same results as b632a98.

852024b:

Also exact same results as b632a98.

Interesting fact, switching to Cordova 6.1 makes also aee2b39 act like the others (remoteParticipant is a blackscreen on iPhone.) , while on Cordova 5.1.1, on first connection, everything works fine, but once remoteParticipant unpublish his video, and publish it again, it becomes black.

@akilude
Copy link
Contributor

akilude commented Jul 31, 2020

Hi,

This doesn't seem to be affecting only twilio, observing same behaviour (remote video only black) with Janus. I am able to receive remote audio.

It works fully with plugin version 6.0.7.

Here is my config that causes the issue:
Cordova: 9
Plugin version - 6.0.12 and master (852024b)
iOS version (e.g 13.4.1)
Xcode version - 11.5 (11E608c)
WebRTC-adapter version 7.6.4
Janus version: v0.10.3
cordova iOS 6.1.0

@hthetiot
Copy link
Contributor Author

Hi,

This doesn't seem to be affecting only twilio, observing same behaviour (remote video only black) with Janus. I am able to receive remote audio.

It works fully with plugin version 6.0.7.

Here is my config that causes the issue:
Cordova: 9 Plugin version - 6.0.12 and master (852024b) iOS version (e.g 13.4.1) Xcode version - 11.5 (11E608c) WebRTC-adapter version 7.6.4 Janus version: v0.10.3 cordova iOS 6.1.0

Thank you, we need to find what changes introduce the issue. It almost look like a he issue is in 6.0.12 but not 6.0.11.

@hthetiot
Copy link
Contributor Author

I will investigate Monday. We need to fix that to release 6.0.13

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 4, 2020

Can you try 6.0.13-RC2 @sboudouk @akilude see changes 402baf4

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 4, 2020

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#6.0.13-RC2 --verbose

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 4, 2020

Notice that debuging with @sboudouk we found that the issue was on swyft and here was the dirty fix 6e30d45 compare to clean 402baf4

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 4, 2020

Last bug for 6.0.13

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 4, 2020

Master tested succesfully with twilio 2.4.0
See test file here https://github.com/cordova-rtc/cordova-plugin-iosrtc-sample/blob/24f8755575395778b6959896f80e5eaf646d310f/www/js/index-twilio.js
cordova-rtc/cordova-plugin-iosrtc-sample@24f8755

@hthetiot hthetiot closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants