Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCPeerConnection.addTrack should return sender #571

Closed
shannah opened this issue Sep 15, 2020 · 2 comments · Fixed by #572
Closed

RTCPeerConnection.addTrack should return sender #571

shannah opened this issue Sep 15, 2020 · 2 comments · Fixed by #572
Assignees
Labels
Milestone

Comments

@shannah
Copy link

shannah commented Sep 15, 2020

RTCPeerConnection.addTrack. should return the RTCRtpSender.

Currently I need to work around it with this:

var sender = conn.addTrack(track, stream);
if (!sender) {
    sender = conn.getSenders().find(function(s){return s.track===track;});
}
@hthetiot
Copy link
Contributor

@shannah thank you, should be fixed by #572 see Testing instruction.

@hthetiot hthetiot added this to the 6.0.14 milestone Sep 15, 2020
@hthetiot hthetiot self-assigned this Sep 15, 2020
@hthetiot
Copy link
Contributor

hthetiot commented Sep 15, 2020

Feel free to comment if that does not fix it, i will re-open.
Notice this a SHAM not a SHIM, I may manage RTCRtpSender instances later on version 8+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants