Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionDescription is NULL #658

Closed
2 of 3 tasks
hthetiot opened this issue Mar 17, 2021 · 6 comments
Closed
2 of 3 tasks

SessionDescription is NULL #658

hthetiot opened this issue Mar 17, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@hthetiot
Copy link
Contributor

hthetiot commented Mar 17, 2021

YOU MUST read first!

Please use Community Forum for general technical discussions and questions.

  • I have used Google with the error message or bug in association with the library and Cordova words to make sure the issue I'm reporting is only related to iOSRTC.
  • I have provided steps to reproduce (e.g. using sample app code https://github.com/cordova-rtc/cordova-plugin-iosrtc-sample or updated extra/renderer-and-libwebrtc-tests.js file).
  • I have provided versions of third party library name, ios, Xcode and plugin version and adapter.js version if used.

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed, removing this checkbox will result in automatic closed issue.

Versions affected

  • Cordova version (e.g 7.1.0): 10
  • Cordova iOS version (e.g 5.1.0): 6.1
  • Plugin version (e.g 6.0.12): 6.0.19
  • iOS version (e.g 10.2): 14.4.1
  • Xcode version (e.g 11.1 - 11A1027): 12
  • WebRTC-adapter version (e.g. 7.4.0): latest
  • WebRTC Framework version (e.g. JSSip 3.1.2): easyrtc

Description

SetRemoteDescription result in SessionDescription is NULL even if sdp is valid.

Steps to reproduce

Expected results

Actual results

@hthetiot hthetiot added this to the 8.0.0 milestone Mar 17, 2021
@hthetiot
Copy link
Contributor Author

Fixed by using master that contains WebRTC M89.

@hthetiot
Copy link
Contributor Author

Chrome 89 is deprecating Plan-B SDPs, and a result, it is adding the a=extmap-allow-mixed line in its SDPs by default. However, these SDPs are not interoperable with WebRTC versions 70 or lower. Because of this the above-mentioned mobile Participants fail to establish media connections with Chrome 89+ Participants.

The solution is to remove a=extmap-allow-mixed from Chrome 89+ SDPs. We are working to update our back end with this solution. In the meantime, you can temporarily work around this issue by passing offerExtmapAllowMixed: false in ConnectOptions in your JavaScript.

Source: https://githubmemory.com/@gjdownes

That why chrome 89 update broken iosRTC 6.x because it use WebRTC 69 while Iosrtc master is on M89 and will be released via 8.0.0

@hthetiot hthetiot self-assigned this Mar 17, 2021
@hthetiot hthetiot added bug libwebrtc webrtc-api webrtc-api related labels Mar 17, 2021
@hthetiot hthetiot reopened this Mar 17, 2021
@hthetiot
Copy link
Contributor Author

Fixed on 6.0.20 next release for 6 LTS

@hthetiot hthetiot modified the milestones: 8.0.0, 6.0.x, 6.0.20 Mar 18, 2021
@hthetiot
Copy link
Contributor Author

Released as 6.0.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant