Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incomplete state update in session.py (function open_xml()) #479

Closed
senderic opened this issue Jun 26, 2020 · 2 comments
Closed

[BUG] Incomplete state update in session.py (function open_xml()) #479

senderic opened this issue Jun 26, 2020 · 2 comments
Assignees
Labels

Comments

@senderic
Copy link

Describe the bug

Incomplete state update in session.py (function open_xml())

To Reproduce

  1. Open file core/session.py
  2. Go to the end of function open_xml()
  3. Should the code under if start: be as follows? Updates are indicated by "#_ADDITION"

start session if needed

if start:
    state = EventTypes.INSTANTIATION_STATE  #_ADDITION
    self.set_state(state) #_ADDITION    
    self.instantiate()

Desktop (please complete the following information):

  • OS: Ubuntu 18.04 or CentOS 7.7.1908

  • CORE Version: 6.3.0

  • EMANE Version: N/A

@senderic senderic added the bug label Jun 26, 2020
@bharnden
Copy link
Contributor

I'll take a glance and compare with normal startup behavior.

@bharnden
Copy link
Contributor

bharnden commented Jun 26, 2020

Odds are this would have no real impact, unless you were trying to use a hook script during this state, the only thing I can think of.

But, I updated this to be consistent with how sessions are started up in other cases.

FIxed on develop.

@bharnden bharnden self-assigned this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants