[BUG] DockerNode creates directories instead of files when calling create_file

[wholderll]

Description
The issue is in DockerNode.create_file, when it creates the parent directories for the new file. On line 204 of docker.py it uses file_path.name where file_path.parent was probably intended, which is preventing the file from being copied to the container.

core/daemon/core/nodes/docker.py

Lines 204 to 209 in 31e6839

	directory = file_path.name
	if str(directory) != ".":
	self.cmd(f"mkdir -m {0o755:o} -p {directory}")
	if self.server is not None:
	self.server.remote_put(temp_path, temp_path)
	self.client.copy_file(temp_path, file_path)

Suggested Fix
Line 204:
directory = file_path.parent

Source

PurePath.name

A string representing the final path component, excluding the drive and root, if any

PurePath.parent

The logical parent of the path

Not sure why pathlib doesn't use Path.filename and Path.directory; understandably not intuitive that a class named Path has a filename for its name and not the directory path.

Environment

• OS: [e.g. Ubuntu 18.04]
• CORE Version [e.g. 5.2.1]
• EMANE Version [e.g. 1.2.4]

[bharnden]

Thanks for pointing this out, I will eventually take a look at this.

[bharnden]

Good catch, it was right for LxcNode's but was updated wrong when some recent adjustments were made. Appreciate it.

Fix is on develop now.