[BUG] Broadcast Address not setting correctly

[adur1990]

Describe the bug
The IPv4 broadcast addresses are not set correctly (always 0.0.0.0), regardless of node type and link type.

To Reproduce
Steps to reproduce the behavior:

1. Place two PC nodes
2. Connect the using the link tool
3. Start the emulation
4. Open a terminal on either of the nodes
5. ifconfig eth0 is showing broadcast 0.0.0.0

Expected behavior
5. ifconfig eth0 should show inet 10.0.0.20 netmask 255.255.255.0 broadcast 10.0.0.255

Desktop (please complete the following information):

• OS: Ubuntu 22.04
• CORE Version 9.0.1

Additional context
Core is running within docker.

[adur1990]

After some investigation and debugging the issue is likely due to the following line:

core/daemon/core/nodes/base.py

Line 895 in 5ab7137

if netaddr.valid_ipv4(ip):

This check is only valid, if ip is a string. But in this case, it is an netaddr.IPNetwork, thus always false...

if netaddr.valid_ipv4(str(ip.ip)): 

fixes the issue...

[bharnden]

Thanks for catching this, fixed on develop for next update release.