Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if /sysroot is not read only #118

Open
travier opened this issue Sep 12, 2022 · 4 comments
Open

Warn if /sysroot is not read only #118

travier opened this issue Sep 12, 2022 · 4 comments
Labels
good-first-issue jira for syncing to jira kind/enhancement New feature or request

Comments

@travier
Copy link
Member

travier commented Sep 12, 2022

See: coreos/fedora-coreos-tracker#1232

Add a warning if we find that /sysroot is not read only.

@dustymabe
Copy link
Member

Hmm. Actually I think this doesn't belong in CLHM. Or maybe it could.

CLHM isn't focused on CoreOS so we need to be smart here. Either we find a way to easily have this not apply on systems where it doesn't make sense (i.e. Fedora Cloud or other) or we should just add this helper in our overlay. I even install CLHM on my desktop 🙂.

Aside: Wherever we add it let's tell the user how to disable the warning if they prefer like we've done with some other things. I think we did that with the cgroups v2 warning.

@travier
Copy link
Member Author

travier commented Sep 13, 2022

Indeed. No problem moving this back to fedora-coreos-config or making this optional here..

@Adam0Brien Adam0Brien self-assigned this Feb 13, 2023
@travier travier transferred this issue from coreos/console-login-helper-messages Feb 13, 2023
@travier
Copy link
Member Author

travier commented Feb 13, 2023

Moved to f-c-c.

@travier travier transferred this issue from coreos/fedora-coreos-config Feb 13, 2023
@travier
Copy link
Member Author

travier commented Feb 13, 2023

And moved back to CLHM. Although we might want it on all installations, having it here will make it easier to include / exclude this warning at the packaging level for different variants / distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue jira for syncing to jira kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants