Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosa leaks git access tokens into generated ociarchive #3355

Open
apollo13 opened this issue Feb 14, 2023 · 2 comments
Open

cosa leaks git access tokens into generated ociarchive #3355

apollo13 opened this issue Feb 14, 2023 · 2 comments

Comments

@apollo13
Copy link

Cosa writes the current config source into the ociarchive:

--label="org.opencontainers.image.source=${gitsrc}" \

In my case this ends up as:

"org.opencontainers.image.source": "https://gitlab-ci-token:XXXX@gitlab.instance.mine",

since I am building in gitlab CI which uses a short lived access token to check out the image. It would be great if this token could be masked.

@cgwalters
Copy link
Member

Other container build systems embed similar data; e.g. I'm pretty sure Tekton does for example. Do they do a similar thing by default? Is there code/logic we chould share?

@apollo13
Copy link
Author

I do not know of any other systems that I have at hand and can try out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants