etcdctl: use a context with -total-timeout in simple commands #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the commit 8ebc933, this commit lets simple etcdctl commands use a context with timeout value passed via -total-timeout. This commit doesn't change complex commands like watch, cluster-health, and import because it is not obvious that using the context in the commands is good or not.
|
LGTM. defer to @xiang90 |
|
It seems that semaphoreci is causing problems:
The latter problem seems to be solved in de1a16e . The first one would be caused by too short timeout value. Should I enlarge the timeout value for solving it? |
I cannot ensure that the problem is caused by short timeout, and the reason that semaphoreci easily fails on this one while travis doesn't. |
|
@yichengq then can I conclude that the problem is caused by semaphoreci not by my PR? |
|
@mitake Yes. It will pass if i rebuild it. |
|
LGTM again. Thanks for totally fixing the timeout flag! |
yichengq
added a commit
that referenced
this pull request
Oct 14, 2015
etcdctl: use a context with -total-timeout in simple commands
|
@yichengq thanks for your review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the commit 8ebc933, this commit lets simple etcdctl commands
use a context with timeout value passed via -total-timeout.
This commit doesn't change complex commands like watch,
cluster-health, and import because it is not obvious that using the
context in the commands is good or not.