*: support get-old-kv in watch #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajityagaty You might want to review this. |
|
Isn't |
| @@ -43,4 +43,7 @@ message Event { | |||
| // A DELETE/EXPIRE event contains the deleted key with | |||
| // its modification revision set to the revision of deletion. | |||
| KeyValue kv = 2; | |||
|
|
|||
| // oldkv holds the KeyValue before the event happens when requested. | |||
| KeyValue oldKV = 3; | |||
|
@chancez @heyitsanthony OK. I think we can rename old_kv to prev_kv. For delete, the original idea was named it as |
|
/cc @hongchaodeng |
| @@ -253,6 +268,14 @@ func (sws *serverWatchStream) sendLoop() { | |||
| events := make([]*mvccpb.Event, len(evs)) | |||
| for i := range evs { | |||
| events[i] = &evs[i] | |||
|
|
|||
| if sws.getOldKV[wresp.WatchID] { | |||
There was a problem hiding this comment.
do map lookup before loop?
|
approach looks fine, but not a fan of the naming |
xiang90
force-pushed
the
get_o_kv
branch
2 times, most recently
from
4b453d5
to
f7f13c7
Compare
|
@heyitsanthony @chancez All fixed. PTAL. |
|
|
||
| // If prevKV is set, created watcher gets the previous KV before the event happens. | ||
| // If the previous KV is already compacted, nothing will be returned. | ||
| bool prevKV = 6; |
There was a problem hiding this comment.
should this be prev_kv, not prevKV?
|
lgtm after protobuf naming style fixups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @heyitsanthony
I will rename the preserve-kv in delete to get-old-kv too. also i will probably add the same option for put.