Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctlv3: fix line parsing for Windows #6387

Merged
merged 1 commit into from
Sep 8, 2016
Merged

ctlv3: fix line parsing for Windows #6387

merged 1 commit into from
Sep 8, 2016

Conversation

sinsharat
Copy link
Contributor

@xiang90
Copy link
Contributor

xiang90 commented Sep 8, 2016

lgtm. Defer to @heyitsanthony

@heyitsanthony
Copy link
Contributor

lgtm

@xiang90 xiang90 merged commit 758f0d9 into etcd-io:master Sep 8, 2016
@xiang90
Copy link
Contributor

xiang90 commented Sep 8, 2016

@sinsharat Thank you!

@sinsharat sinsharat deleted the fix_ctl_win branch September 9, 2016 06:30
@sinsharat
Copy link
Contributor Author

@xiang90 i am actually thankful to you for helping me out. I will always try to contribute to etcd in whichever way i can.
Thanks once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sinsharat @xiang90 @heyitsanthony @gyuho