Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: only return closing error to watcher if context is not canceled #6582

Merged
merged 2 commits into from
Oct 5, 2016
Merged

clientv3: only return closing error to watcher if context is not canceled #6582

merged 2 commits into from
Oct 5, 2016

Conversation

heyitsanthony
Copy link
Contributor

Fixes #6503

/cc @hongchaodeng

@xiang90
Copy link
Contributor

xiang90 commented Oct 4, 2016

LGTM

@heyitsanthony
Copy link
Contributor Author

merging. Should we backport this?

@heyitsanthony heyitsanthony merged commit b980ab0 into etcd-io:master Oct 5, 2016
@gyuho
Copy link
Contributor

gyuho commented Oct 5, 2016

yeah let's add a label since it's simple fix.

@heyitsanthony heyitsanthony deleted the fix-cancel-close branch October 12, 2016 21:18
@sinsharat sinsharat mentioned this pull request Oct 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyitsanthony @xiang90 @gyuho