Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON endpoints configurable #8

Open
jlebon opened this issue Jan 16, 2020 · 2 comments
Open

Make JSON endpoints configurable #8

jlebon opened this issue Jan 16, 2020 · 2 comments

Comments

@jlebon
Copy link
Member

jlebon commented Jan 16, 2020

I'd like to be able to write upgrade tests that require talking to a local dumnati server serving test-specific metadata. Right now, the releases.json and ${stream}.json is hardcoded into the app. Can we make these be configurable somehow? I see it doesn't use config files yet, and maybe we don't want to go all the way there until we sort out the merger with Cincinnati -- maybe just env vars for now would work?

@jlebon
Copy link
Member Author

jlebon commented Jan 16, 2020

I'd like to be able to write upgrade tests that require talking to a local dumnati server serving test-specific metadata.

Hmm, actually... I guess I could hack this up without using dumnati at all by just serving the JSON at the URL zincati will hit. A bit underhanded, and implies it's not entirely testing zincati itself, though it simplifies the setup quite a bit.

@lucab
Copy link
Contributor

lucab commented Jan 20, 2020

I've left a TODO to figure out the configuration story:

// TODO(lucab): figure out all configuration params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants