Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: new release on 2020-11-17 (33.20201116.2.0) #221

Closed
35 tasks done
sohankunkerkar opened this issue Nov 5, 2020 · 12 comments
Closed
35 tasks done

testing: new release on 2020-11-17 (33.20201116.2.0) #221

sohankunkerkar opened this issue Nov 5, 2020 · 12 comments
Assignees

Comments

@sohankunkerkar
Copy link
Member

sohankunkerkar commented Nov 5, 2020

First, verify that you meet all the prerequisites

Name this issue testing: new release on YYYY-MM-DD with today's date. Once the pipeline spits out the new version ID, you can append it to the title e.g. (31.20191117.2.0).

Pre-release

Promote testing-devel changes to testing

From the checkout for fedora-coreos-config (replace upstream below with
whichever remote name tracks coreos/):

  • git fetch upstream
  • git checkout testing
  • git reset --hard upstream/testing
  • /path/to/fedora-coreos-releng-automation/scripts/promote-config.sh testing-devel
  • Sanity check promotion with git show
  • Open PR against the testing branch on https://github.com/coreos/fedora-coreos-config
  • Post a link to the PR as a comment to this issue
  • Ideally have at least one other person check it and approve
  • Once CI has passed, merge it

Build

  • Start a pipeline build (select testing, leave all other defaults)
  • Post a link to the job as a comment to this issue
  • Wait for the job to finish

Sanity-check the build

Using the the build browser for the testing stream:

  • Verify that the parent commit and version match the previous testing release (in the future, we'll want to integrate this check in the release job)
  • Check kola AWS run to make sure it didn't fail
  • Check kola GCP run to make sure it didn't fail

⚠️ Release ⚠️

IMPORTANT: this is the point of no return here. Once the OSTree commit is
imported into the unified repo, any machine that manually runs rpm-ostree upgrade will have the new update.

Run the release job

  • Run the release job, filling in for parameters testing and the new version ID
  • Post a link to the job as a comment to this issue
  • Wait for job to finish
  • Verify that the OSTree commit and its signature are present and valid by booting a VM at the previous release (e.g. cosa run --qemu-image /path/to/previous.qcow2) and verifying that rpm-ostree upgrade works and rpm-ostree status shows a valid signature.

At this point, Cincinnati will see the new release on its next refresh and create a corresponding node in the graph without edges pointing to it yet.

Refresh metadata (stream and updates)

From a checkout of this repo:

  • Update stream metadata, by running:
fedora-coreos-stream-generator -releases=https://fcos-builds.s3.amazonaws.com/prod/streams/testing/releases.json  -output-file=streams/testing.json -pretty-print
  • Update the updates metadata, editing updates/testing.json:
    • Find the last-known-good release (whose rollout has a start_percentage of 1.0) and set its version to the most recent completed rollout
    • Delete releases with completed rollouts
    • Add a new rollout:
      • Set version field to the new version
      • Set start_epoch field to a future timestamp for the rollout start (e.g. date -d '20yy/mm/dd 14:30UTC' +%s)
      • Set start_percentage field to 0.0
      • Set duration_minutes field to a reasonable rollout window (e.g. 2880 for 48h)
    • Update the last-modified field to current time (e.g. date -u +%Y-%m-%dT%H:%M:%SZ)

A reviewer can validate the start_epoch time by running date -u -d @<EPOCH>. An example of encoding and decoding in one step: date -d '2019/09/10 14:30UTC' +%s | xargs -I{} date -u -d @{}.

  • Commit the changes and open a PR against the repo.
  • Post a link to the PR as a comment to this issue
  • Wait for the PR to be approved.
  • Once approved, merge it and verify that the sync-stream-metadata job syncs the contents to S3
  • Verify the new version shows up on the download page
  • Verify the incoming edges are showing up in the update graph
Update graph manual check
curl -H 'Accept: application/json' 'https://updates.coreos.fedoraproject.org/v1/graph?basearch=x86_64&stream=testing&rollout_wariness=0'

NOTE: In the future, most of these steps will be automated.

Housekeeping

  • If one doesn't already exist, open an issue in this repo for the next release in this stream. Use the approximate date of the release in the title.
  • Check the overrides lockfiles in the configs repo for the testing-devel stream to see if any overrides are obsolete. They are obsolete if the RPMs (or newer ones) have hit the stable Fedora repos. You can usually see this by following the Bodhi link in the lockfile and checking whether the update was pushed to stable or was obsoleted by an update which was pushed to stable.
    • If a PR was created post a link to the PR as a comment to this issue.
@dustymabe
Copy link
Member

Note. This should be the first testing stream release rebased onto Fedora 33.

@travier
Copy link
Member

travier commented Nov 17, 2020

Promotion PR: coreos/fedora-coreos-config#738

@travier
Copy link
Member

travier commented Nov 17, 2020

@dustymabe
Copy link
Member

oh fun:

docker.io/openshift/jenkins-slave-base-centos7: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@travier
Copy link
Member

travier commented Nov 17, 2020

@travier travier changed the title testing: new release on 2020-11-17 testing: new release on 2020-11-17 (33.20201116.2.0) Nov 18, 2020
@travier
Copy link
Member

travier commented Nov 18, 2020

@travier
Copy link
Member

travier commented Nov 18, 2020

Rollout PR: #225

@dustymabe
Copy link
Member

Rollout PR: #225

followup to make it a barrier release: #227

This has no real effect today, but let's go ahead and get it in so we don't forget it when we rollout the next release.

@dustymabe
Copy link
Member

The OpenStack kola run was green too: https://jenkins-fedora-coreos.apps.ocp.ci.centos.org/job/kola-openstack/15/

@travier
Copy link
Member

travier commented Nov 18, 2020

The OpenStack kola run was green too: https://jenkins-fedora-coreos.apps.ocp.ci.centos.org/job/kola-openstack/15/

Nice! Is this available on all streams? Should we add that to the release task list?

@dustymabe
Copy link
Member

The OpenStack kola run was green too: https://jenkins-fedora-coreos.apps.ocp.ci.centos.org/job/kola-openstack/15/

Nice! Is this available on all streams? Should we add that to the release task list?

yep! #228

@travier travier closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants