This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1/fly: record pgid and let stop fallback to it #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an additional "pgid" file, specific to stage1-fly implementation, to record the process group of the pod. It is used by stop as a fallback mechanism if the pod-leader process is gone but some daemonized children still exist, leaving the pod in an unkillable status.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an additional "pgid" file, specific to stage1-fly
implementation, to record the process group of the pod.
It is used by stop as a fallback mechanism if the pod-leader process
is gone but some daemonized children still exist, leaving the pod
in an unkillable status.
Fixes #3295