This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage0/app-add: CLI args should override image ones #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This introduces a minor CLI breaking change for
|
20 tasks
|
An alternative path here is to just change the app-add behavior for the moment, announce the behavioral change for run on the ML and switch it later (eg. in 2 release cycles). |
|
Since this is mostly needed for CRI/rktlet I am voting for announcing this breaking change for |
lucab
force-pushed
the
to-upstream/stage0-args-override
branch
from
59280ab to
9c7a66f
Compare
|
Ack. I dropped the run part out of here, so now this only changes app-add behavior. PTAL. |
lucab
changed the title
|
I'll take "stupid slice tricks for $200, Alex". Nice. |
This commit uniforms app args and exec command, so that in both cases CLI parameters always override image ones.
lucab
force-pushed
the
to-upstream/stage0-args-override
branch
from
9c7a66f to
aa4e4bf
Compare
|
(re-pushed as CI hooks didn't trigger) |
|
ok to test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uniforms app args and exec command, so that in both cases
CLI parameters always override image ones.