Allow to change overrides during a rebase

[YaLTeR]

Host system details

I have firefox removed as I'm using the Flatpak version:

State: idle
Deployments:
● fedora:fedora/36/x86_64/silverblue
                  Version: 36.20220808.0 (2022-08-08T00:44:29Z)
               BaseCommit: 2a4756e2374156fb939a65cb6a47c1a75c327e0896ea7cad6c747346b09a0a51
             GPGSignature: Valid signature by 53DED2CB922D8B8D9E63FD18999F7CBF38AB71F4
      RemovedBasePackages: firefox 103.0.1-2.fc36
          LayeredPackages: alacritty exa fish flatpak-builder i3 langpacks-ru perf sysprof
                Initramfs: --include /etc/initramfs-overlay /
                   Pinned: yes

Expected vs actual behavior

Rebasing to F37 fails due to the new firefox-langpacks:

┌ ~
└─ rpm-ostree rebase fedora/37/x86_64/silverblue
⠈ Receiving objects; 99% (24727/24854) 3,7 MB/s 1,1 GB
Receiving objects; 99% (24727/24854) 3,7 MB/s 1,1 GB... done
Checking out tree 76acf2a... done
Enabled rpm-md repositories: fedora-cisco-openh264 fedora-modular updates-modular updates fedora updates-archive
Updating metadata for 'fedora-cisco-openh264'... done
Updating metadata for 'fedora-modular'... done
Updating metadata for 'updates-modular'... done
Updating metadata for 'updates'... done
Updating metadata for 'fedora'... done
Updating metadata for 'updates-archive'... done
Importing rpm-md... done
rpm-md repo 'fedora-cisco-openh264'; generated: 2022-04-07T17:51:06Z solvables: 4
rpm-md repo 'fedora-modular'; generated: 2022-08-17T19:23:00Z solvables: 1491
rpm-md repo 'updates-modular'; generated: 2022-08-09T18:08:16Z solvables: 0
rpm-md repo 'updates'; generated: 2022-08-09T18:08:15Z solvables: 0
rpm-md repo 'fedora'; generated: 2022-08-16T09:56:35Z solvables: 68799
rpm-md repo 'updates-archive'; generated: 2022-02-11T15:19:10Z solvables: 0
Resolving dependencies... done
error: Could not depsolve transaction; 1 problem detected:
 Problem: package firefox-langpacks-103.0.1-2.fc37.x86_64 requires firefox = 103.0.1-2.fc37, but none of the providers can be installed
  - conflicting requests

I can't install firefox in the same transaction because it's an override:

┌ ~
└─ rpm-ostree rebase fedora/37/x86_64/silverblue --install=firefox
error: "firefox" is already provided by: firefox-103.0.1-2.fc36.x86_64. Use --allow-inactive to explicitly require it.

I also can't remove firefox-langpacks before it exists:

┌ ~ 1
└─ rpm-ostree override remove firefox-langpacks
error: Package "firefox-langpacks" not found

I have to do the following in three steps:

$ rpm-ostree override reset firefox
$ rpm-ostree rebase fedora/37/x86_64/silverblue
$ rpm-ostree override remove firefox firefox-langpacks

Expected:

A way to adjust overrides in the same transaction:

$ rpm-ostree rebase fedora/37/x86_64/silverblue --override-remove firefox-langpacks
...
Success!

[cgwalters]

Yeah, I think I hit this once myself. Ultimately, I think the solution though will be #2326 instead of having more and more ad-hoc CLI flags. Does that appeal to you too?

[YaLTeR]

So you'd have a configuration file for your system where you would, at the same time, bump "base" to f37 and add "firefox-langpacks" to the "override-remove" list, then run "rpm-ostree rebuild"? That sounds good, although I'd still keep rpm-ostree install and some other subcommands because it's faster to use. They could update the configuration and rebuild the system in one step, rolling back if it wasn't successful.

[CleoMenezesJr]

My workaround, I run a reset for Firefox with: rpm-ostree override reset firefox. Then I managed to rebase to Fedora 37.
Instead of removing Firefox and creating unnecessary overrides, I simply preferred to hide the icon with:

cp /usr/share/applications/firefox.desktop ~/.local/share/applications/
desktop-file-edit --set-key=NoDisplay --set-value=true ~/.local/share/applications/firefox.desktop
xdg-settings set default-web-browser org.mozilla.firefox.desktop

To be honest, I would like Silverblue to have some minimal installation about applications, as I would like to have all my possible apps were flatpak.