Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit / UnitIdentifier on OrderItem #2384

Open
solverat opened this issue Oct 4, 2023 · 1 comment
Open

Unit / UnitIdentifier on OrderItem #2384

solverat opened this issue Oct 4, 2023 · 1 comment
Assignees
@solverat
Labels
bug

Comments

@solverat
Copy link
Contributor

solverat commented Oct 4, 2023

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

In CS2, the CartItemToSaleItemTransformer added two additional data blocks to the order item:

$toProposal->setUnitIdentifier($unit->getName());
$toProposal->setUnit($unit->getId());

I've added those setters back then to ensure that the unit wont get lost in case the unitdefinition gets removed / changed.

The setter/getters are still there, so I'm wondering if we could reimplement them?
@dpfaffenbauer
Copy link
Member

sure, please pr

@dpfaffenbauer dpfaffenbauer added this to the 3.2.0 milestone Oct 4, 2023
@dpfaffenbauer dpfaffenbauer removed this from the 3.2.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solverat solverat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solverat @dpfaffenbauer