Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-breadcrumb.service.ts has wrong import from "rxjs" so causes overhead in resulted bundle #22

Closed
nazar-kuzo opened this issue Sep 27, 2018 · 3 comments

Comments

@nazar-kuzo
Copy link

app-breadcrumb.service.ts has wrong import from "rxjs" so causes overhead in resulted bundle

File
coreui-angular/projects/coreui/angular/src/lib/breadcrumb/app-breadcrumb.service.ts

Line
import { Observable } from 'rxjs/index';

Expected
import { Observable } from 'rxjs';

@xidedix
Copy link
Member

xidedix commented Oct 25, 2018

thanks @nazar-kuzo
PR welcome!

@sparun160782
Copy link
Contributor

sparun160782 commented Mar 18, 2019

I have corrected and committed the code as excepted and also merged the same issue is also at
@coreui/angular/fesm5/coreui-angular.js which is also corrected. Kindly rectify as quick as possible since we unable to run the project.

@xidedix
Copy link
Member

xidedix commented Mar 18, 2019

closed by #56

@xidedix xidedix closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants