Skip to content

Commit a45836b

Browse files
committed
test: make them pass, + downgrade typescript to 2.8 for immutable-js/immutable-js#1540
1 parent 7c5ab47 commit a45836b

File tree

6 files changed

+11
-13
lines changed

6 files changed

+11
-13
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"tsickle": "^0.32.0",
3838
"tslib": "^1.9.0",
3939
"tslint": "~5.11.0",
40-
"typescript": "~2.9.2",
40+
"typescript": "~2.8.4",
4141
"zone.js": "^0.8.26"
4242
},
4343
"scripts": {

packages/examples/src/app/xy-pad/box-drag-preview/box-drag-preview.component.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,4 @@ import { Subject } from 'rxjs';
3939
]
4040
})
4141
export class BoxDragPreviewComponent implements OnInit {
42-
@Input() title;
43-
44-
constructor() {}
45-
46-
ngOnInit() {}
4742
}

packages/examples/src/app/xy-pad/crosshairs.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import { Component, Input } from '@angular/core';
1414
})
1515
export class CrosshairsComponent {
1616
math = Math;
17-
@Input() x: number;
18-
@Input() y: number;
17+
@Input() x!: number;
18+
@Input() y!: number;
1919
@Input() width: number = 400;
2020
@Input() height: number = 400;
2121
}

packages/examples/src/app/xy-pad/spot.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,5 @@ import { Component, OnInit, Input } from '@angular/core';
2020
]
2121
})
2222
export class SpotComponent {
23-
@Input() title: string;
2423
@Input() compensate = false;
2524
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
export class Spot {
1+
export interface Spot {
22
id: number;
33
x: number;
44
y: number;
5-
fromCube?: boolean = false;
6-
}
5+
fromCube?: boolean;
6+
}

yarn.lock

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9190,10 +9190,14 @@ typescript@2.8.3:
91909190
version "2.7.2"
91919191
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.7.2.tgz#2d615a1ef4aee4f574425cdff7026edf81919836"
91929192

9193-
typescript@^2.4.2, typescript@~2.9.1, typescript@~2.9.2:
9193+
typescript@^2.4.2, typescript@~2.9.1:
91949194
version "2.9.2"
91959195
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.9.2.tgz#1cbf61d05d6b96269244eb6a3bce4bd914e0f00c"
91969196

9197+
typescript@~2.8.4:
9198+
version "2.8.4"
9199+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.8.4.tgz#0b1db68e6bdfb0b767fa2ab642136a35b059b199"
9200+
91979201
ua-parser-js@^0.7.18:
91989202
version "0.7.18"
91999203
resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.18.tgz#a7bfd92f56edfb117083b69e31d2aa8882d4b1ed"

0 commit comments

Comments
 (0)