-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Ability to choose chrono instead of time #209
Comments
The simplest solution for now, would be to use In postgres, timestamps are just microseconds and dates are just number of day. We should use types that match this reality. |
I didn't know SystemTime can be used to store historical dates..? Either way I think the feature approach I mentioned might make more sense though, as postgres-types does it this way. I don't think it makes use of SystemTime at all. |
@jacobsvante I didn't add chrono support originally because of the whole unsoundness debacle. I tried to not include crates with serious known vulnerabilities. This has been fixed in version 4.20, but only if you disable default features and don't enable the In any case, disregarding the soundness issues, this will probably be actionable via the new codegen architecture #211. |
Okay, sounds good 👍 |
Currently time fields seem bound to the
time
library. Working with time zones withtime
is a PITA so I was saddened to see that cornucopia does not support chrono.Might implement this myself after Easter. @LouisGariepy @Virgiel Should I implement as a crate feature, e.g.
chrono
+time
wheretime
is default?Or maybe #207 would solve this?
The text was updated successfully, but these errors were encountered: