Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

High risk removed from contact journal #5031

Closed
3 tasks
DerVogel2020 opened this issue Apr 4, 2022 · 11 comments
Closed
3 tasks

High risk removed from contact journal #5031

DerVogel2020 opened this issue Apr 4, 2022 · 11 comments
Labels
bug Something isn't working

Comments

@DerVogel2020
Copy link
Contributor

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
  • Bug is not already reported in another issue

Technical details

  • Device name:
  • Android version: 8
  • App version: 2.20

Describe the bug

I had a red tile in the app. Today it is gone, because the risk calculation only considers 10 days now.
But I expect this contacts still to be shown in the journal because there are still 15 days shown.

Steps to reproduce the issue

  1. Have a contact
  2. Wait 11 days
  3. See the contact journal

Expected behaviour

The entry at e.g. Tuesday 2 weeks ago was there and should stay there as long as the days is shown in the journal.

@DerVogel2020 DerVogel2020 added the bug Something isn't working label Apr 4, 2022
@MikeMcC399
Copy link
Contributor

@DerVogel2020

@DerVogel2020
Copy link
Contributor Author

Thanks. I looked for the first one, but in the wrong repositories.😉

@MikeMcC399
Copy link
Contributor

@DerVogel2020

Thanks. I looked for the first one, but in the wrong repositories.😉

I used the search field in the top left of GitHub and typed org:corona-warn-app is:issue is:open journal in:title to find it. It's quite tricky sometimes with all the different repositories.

@mtwalli
Copy link
Contributor

mtwalli commented Sep 13, 2022

I can't reproduce this issue, High risk is not removed from contact diary after 11 days, please provide error log if you can re-produce it ?
see recording:

risk.mp4

@mtwalli mtwalli closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Sep 13, 2022

@mlenkeit Did the device perform a new risk check on 23/09/2022 (i.e. do you still see the red encounter on the "Status" tab or only the failed card)?

@mtwalli
Copy link
Contributor

mtwalli commented Sep 13, 2022

@mlenkeit Did the device perform a new risk check on 23/09/2022 (i.e. do you still see the red encounter on the "Status" tab or only the failed card)?

@Ein-Tim I think you mean me.It did not. I see failed risk card. do you think future calculations matter in this occasion?. as far as I know when high risk is reported from ENS or ChecksIns it is saved in contact diary database independently from risk calculation

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Sep 13, 2022

@mtwalli I guess if the app would turn green again the contact would also be removed from the contact journal, maybe you could test that?

Because AFAIK the current implementation, at least under iOS, is that risk encounters are removed from the contact journal after they are not displayed anymore on the "Status" tab.

@DerVogel2020
Copy link
Contributor Author

@mtwalli started error logging and will check in a few days.

@DerVogel2020
Copy link
Contributor Author

DerVogel2020 commented Sep 20, 2022

@mtwalli this still occurs.
The error log is ID 6A10B254EB600F352CBE

I can provide a screenshot from yesterday and from today, where the entry of 9.9.2022 is gone.

@mtwalli mtwalli reopened this Sep 20, 2022
@mtwalli
Copy link
Contributor

mtwalli commented Oct 17, 2022

@DerVogel2020 You are right that the risk disappears from contact journal after 10 days (atm). There was an intended change in v2.20 to restrict exposure history to specific age (configurable from AppConfig) at the moment it is 10 days.
Change in the app meant:

for ENF, when obtaining Exposure Windows, they are filtered by age against a parameter from the app config before any other processing (risk calculation, PPA, contact journal, etc.)
for event registration, check-ins are filtered by age against a parameter from the app config.

Therefore it is not a bug, however I see that this can be still confusing to the user and Contact Journal might be restricted to configurable age too.
Fortunately there is a swishlist request for that corona-warn-app/cwa-wishlist#815

@mtwalli
Copy link
Contributor

mtwalli commented Mar 9, 2023

As I mentioned earlier, this is working as designed and no plan to change it in the future.

@mtwalli mtwalli closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants