Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Publish security audits #579

Open
rugk opened this issue Apr 8, 2021 · 13 comments
Open

Publish security audits #579

rugk opened this issue Apr 8, 2021 · 13 comments
Assignees
Labels
mirrored-to-jira This item is also tracked internally in JIRA question Further information is requested

Comments

@rugk
Copy link
Contributor

rugk commented Apr 8, 2021

Your Question

As far as I read the doc there, you seem to acknowledge to do (external?) security audits of your code etc.

  • Did you do so?
  • If so, could you publish the results? (with all vulnerabilities that are fixed, of course)

I'm talking about technical security audits (code audits/blackbox or whitebox-like etc.), not GDPR/privacy analyses/statements etc.


Internal Tracking-ID: EXPOSUREAPP-8354

@rugk rugk added the question Further information is requested label Apr 8, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 8, 2021

https://www.coronawarn.app/en/#privacy under the point "Security" also says:

"Security assurance of application development through Secure Software Development Lifecycle, which includes among other things threat modeling and end-to-end risk assessment, security planning, security testing and penetration testing."

I didn't find a link to these threat modelings, etc. there neither.

@rugk
Copy link
Contributor Author

rugk commented Apr 10, 2021

That's great and interesting, but not really a security audit from an external company...

@dsarkar dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label Apr 12, 2021
@dsarkar
Copy link
Member

dsarkar commented Apr 12, 2021

@rugk I will try to get some info. Internal Tracking ID: EXPOSUREAPP-5956

@Ein-Tim
Copy link
Contributor

Ein-Tim commented May 7, 2021

Penetration test were also mentioned in https://dbtg.tv/cvid/7519454 at around minute 12.

@rugk
Copy link
Contributor Author

rugk commented Jun 19, 2021

FYI the BSI responded to some FOI („freedome of information”, IFG - Informationsfreiheitsgesetz) request and thus published some audits:
https://fragdenstaat.de/anfrage/dokumente-zu-sicherheitsaudits-der-corona-warn-app/#nachricht-590020

Dokumente_geschwrzt.zip

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 9, 2021

The BSI responded to a question I asked them on Twitter, it's not planned to publish the security audits ("Eine Veröffentlichung der Berichte als solches ist aktuell nicht geplant.").

@rugk
Copy link
Contributor Author

rugk commented Jul 9, 2021

This is funny, because they actually did publish some of them in/via the FOI request above… 🙃

I asked them why they don't do this. 😅

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 9, 2021

@rugk

Is the argument from the Twitter user a valid one? For me it sounds logically that they won't publish these audits because hackers then would know what doesn't work and can concentrate on other methods. But tbh I never read through a security audit so 🤷🏻‍♂️
And, on the other side, they are still reporting security flaws public here on GitHub, sooo. 😉

@rugk
Copy link
Contributor Author

rugk commented Jul 9, 2021

@Ein-Tim I already replied on Twitter but the TLDR is, as you also said: Of course do not publish unfixed/undisclosed vulnerabilities. As for fixed ones, however, there is – judging from the technical experience – no disadvantage/risk of just publishing it. Especially as they, as you noticed, are already somewhat public on GitHub.

@heinezen
Copy link
Member

@rugk I've raised the issue again, this time as a feature request.

@Ein-Tim

Is the argument from the Twitter user a valid one? For me it sounds logically that they won't publish these audits because hackers then would know what doesn't work and can concentrate on other methods.

It goes against all security best pratices, so no, it isn't really valid.

  1. You actually want people to know how to test these systems, otherwise no one could comprehend whether the issue is fixed or how severe the problem was in the first place. You cannot trust if something is secure if the methods to determine this are unknown.
  2. The chances that university/security researchers will find bugs and report them is much higher when they can base their work on previous audits
  3. The "evil guys" usually already have a fair bit of pentesting knowledge and don't need the help of an audit

Corona-Warn-App Open Source Team

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 11, 2021

@heinezen

Thank you for the explanation (and for rising this topic again)!

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 18, 2022

Is there any update available here? Will security audits be published directly on GitHub or is it necessary to request them via a FOI request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mirrored-to-jira This item is also tracked internally in JIRA question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants