Business Rules - Spain - passes with 1/2 vaccination certificate

[MikeMcC399]

Technical details

• Device name: Samsung Galaxy A5 (2017) SM-A520F
• Android version: 8.0.0
• App version: 2.6.1

Describe the bug

With a 1/2 vaccination certificate (incomplete series) the validity check for Spain passes instead of failing.

https://reopen.europa.eu/en/from-to/DEU/ESP however says:
COVID-19 Vaccination Certificate. Valid 14 days after receiving the complete regimen

Steps to reproduce the issue

1. Scan in 1/2 vaccination certificate
2. CHECK VALIDITY
3. Select Country Spain / Date 1 Aug 2021 12:00
4. Result is "Your certificate is valid in the selected country"
   "2 rules of the destination country were reviewed successfully.

Expected behavior

Since the series is incomplete (1 of 2 doses and the 2nd dose is not documented) the validation should fail.

Possible Fix

Examine the Spanish business rules.

Additional context

2021-07-30T17:24:59.875Z I/CertLogicEngineWrapper: Rule VR-ES-0002 1.0.0 has resulted in PASSED.
2021-07-30T17:24:59.875Z I/CertLogicEngineWrapper: Rule VR-ES-0003 1.0.0 has resulted in PASSED.

[thomasaugsten]

I forwarded this finding. The important rule VR-ES-0001 is in the test data but not on the rule gateway.

[vaubaehn]

Hi @thomasaugsten (and possibly @carballAcc ?)
could you also please have a look at
TR-ES-0003 and
TR-ES-0004:
They're both for validity of sample collection of NAA-Test, but 0003 is "not older than 48 hours" and 0004 is "not older than 72 hours", so rule TR-ES-0004 is obsolete. (PROD data yesterday in gateway)

Is there a good platform/repo where these issues could be reported?

[carballAcc]

Good morning, rule VR-ES-0001 has been restored and TR-ES-004 has been corrected. Thank you all

[thomasaugsten]

Thanks @carballAcc for fixing this issue so fast.

[vaubaehn]

@carballAcc
Thanks for your reply!

@thomasaugsten @MikeMcC399
The updated rules for ES are already in PROD, but will take effect from 05.08.2021 on.
Just in case someone else stumbles over ES...

[MikeMcC399]

@vaubaehn
Thanks for the information about date of introduction of the fix.

@thomasaugsten
We have usually left issues open until a fix is in production or an app version with the fix has been released, otherwise users tend to open duplicate issues. Also I have no way of verifying the fix at this time, so for me the issue is still open.

[vaubaehn]

@MikeMcC399

Also I have no way of verifying the fix at this time

I added some interesting information a minute ago:
https://covidapps.slack.com/archives/C0194ML0MLN/p1627991943008300?thread_ts=1627556597.041700&cid=C0194ML0MLN

[MikeMcC399]

@vaubaehn
Thanks for your trouble about debugging rules. I'm not going to dive into this right now. Hopefully the app (or at least the debug version of the app) will divulge some of this information in future without requiring extensive internal and debug knowledge.

Thanks also once again for your tip about the date. I realised that it was not true that I could not verify the fix. All I had to do was to state:

Country: Spain
Entry date and local time: 05.08.2021 02:00

and I received the error:
"Your certificate is not valid in the selected country
The vaccination schedule must be complete (e.g., 1/2, 2/2)
Rule ID
VR-ES-0001 (1.0.0)"

Do the rules work on UTC time? Entry on 05.08.2021 01:00 still produced an (incorrect) success message, whereas stating entry one hour later, at 02:00, produced the expected fail.