Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German language text in English Android vaccination screenshot #1960

Closed
MikeMcC399 opened this issue Oct 25, 2021 · 2 comments
Closed

German language text in English Android vaccination screenshot #1960

MikeMcC399 opened this issue Oct 25, 2021 · 2 comments
Assignees
Labels
bug Something isn't working screenshots New Screenshots provided

Comments

@MikeMcC399
Copy link
Contributor

Where to find the issue

Screenshots 2.12 -Android - Vaccination Certificate

https://www.coronawarn.app/assets/screenshots/2-12/en/android/VaccinationDetailsFragment_immune.png

Describe the issue

The image https://www.coronawarn.app/assets/screenshots/2-12/en/android/VaccinationDetailsFragment_immune.png

contains the German text "Dieser QR Code lässt sich verlässlich mit der CovPassCheck-App überprüfen." in an old screen shot of an English language Vaccination Certificate screen which does not correspond to the final release of CWA Android 2.12.1. This issue is also present in the 2.11 screenshot.

The text from string person_details_certificate_covpass_info_title should be "This QR code can be verified reliably with the CovPassCheck app.". You can tell that it is a screenshot with locale set to English, because the button is labelled in English "CHECK VALIDITY".

VaccinationDetailsFragment_immune mixed language

(In fact also the German text in the German screen shot is out-of-date, where the text should be "Dieser QR-Code lässt sich verlässlich mit der CovPassCheck-App überprüfen.". Note that in the final release there is a hyphen between QR and Code. So in https://www.coronawarn.app/assets/screenshots/2-12/de/android/VaccinationDetailsFragment_immune.png the German-language screen shot does not exactly match the released CWA 2.12.1 either.)

The screenshots have less value if they are not a reliable reference of the state of the released app.

Suggested change

To correct this, a screenshot from the released version CWA 2.12.1 needs to be taken and published.

@MikeMcC399 MikeMcC399 added the bug Something isn't working label Oct 25, 2021
@dsarkar dsarkar self-assigned this Oct 25, 2021
@dsarkar dsarkar added the screenshots New Screenshots provided label Oct 25, 2021
@MikeMcC399
Copy link
Contributor Author

It seems it is not possible to generate an Android immune vaccination (complete) screenshot with the correct blue background color at this time, so I logged the issue corona-warn-app/cwa-app-android#4279 against cwa-app-android.

@MikeMcC399
Copy link
Contributor Author

This issue is fixed by PR #1965. Thanks to @larswmh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working screenshots New Screenshots provided
Projects
None yet
Development

No branches or pull requests

2 participants