Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated link checking? #889

Closed
MikeMcC399 opened this issue Feb 14, 2021 · 4 comments
Closed

Automated link checking? #889

MikeMcC399 opened this issue Feb 14, 2021 · 4 comments
Labels
question Further information is requested

Comments

@MikeMcC399
Copy link
Contributor

Your Question

Is there some way to automate checking of links used by https://www.coronawarn.app/ to identify failed links, like the one reported in #886?

In the cwa-documentation repository there is a check in
checks.yml

      - name: Checking for broken links
        if: always()
        run: |
          npm run-script checklinks

unfortunately this can't be taken 1:1 because it only checks markdown files *.md

"checklinks": "find . -not -path \"*node_modules*\" -not -path \"*.github*\" -name \"*.md\" | xargs -n 1 markdown-link-check",

Perhaps there is something similar which could be used on https://www.coronawarn.app/?

@MikeMcC399 MikeMcC399 added the question Further information is requested label Feb 14, 2021
@heinezen
Copy link
Member

cwa-documentation has the advantage that all files are pure static Markdown. For the website, Markdown (blogposts) and JSON files with HTML (FAQ) are compiled into the resulting website, so we might not be able to just check the source files for errors. This would make a solution more complicated. However, we could check the output of the build because that is HTML-only. Not sure how easy this would be.


Corona-Warn-App Open Source Team

@MikeMcC399
Copy link
Contributor Author

@dsarkar
There are major changes to links in the open PR #1772 for the analysis page.

How can these links be checked to make sure they all work?

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Sep 29, 2021

Links are still broken, see #1778.

Edit: now fixed.

@MikeMcC399
Copy link
Contributor Author

Closing in favour of feature request #1781.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants