Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return value for fake EC #56

Open
Drovosek01 opened this issue Nov 5, 2022 · 0 comments
Open

Return value for fake EC #56

Drovosek01 opened this issue Nov 5, 2022 · 0 comments

Comments

@Drovosek01
Copy link

Drovosek01 commented Nov 5, 2022

Using the SSDTTime script, I extracted DSDT on Windows and generated FakeEC tables for my Chinese x79 motherboard

Some time later, while studying the instructions, I looked in detail at the source code of ST EC Desktop, which lies in the OpenCore repository
https://github.com/dortania/Getting-Started-With-ACPI/blob/master/extra-files/decompiled/SSDT-EC-DESKTOP.dsl
and I saw that the returned values in the file from the repository and in the generated file are oppositely different

In the dsl file generated by SSDTTIme, here is a condition with return values:

image

If (_OSI ("Darwin"))
{
Return (0x0F)
}
Else
{
Return (Zero)
}

And in the dsl file from the OpenCore repository , this is:

https://github.com/dortania/Getting-Started-With-ACPI/blob/master/extra-files/decompiled/SSDT-EC-DESKTOP.dsl#L560

If (_OSI ("Darwin"))
{
Return (Zero)
}
Else
{
Return (0x0F)
}

Actual questions:

  1. Is there a difference between such return values?
  2. Which option is correct in this case?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant