Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 support #61

Closed
huard opened this issue Nov 4, 2019 · 4 comments
Closed

Python 3.5 support #61

huard opened this issue Nov 4, 2019 · 4 comments

Comments

@huard
Copy link

huard commented Nov 4, 2019

Code Sample, a copy-pastable example if possible

import rioxarray

Problem description

Import seems to fail on Python 3.5 with version 0.0.15.
Python 3.5 does not seem to be part of the Travics-CI suite.

>>> import rioxarray
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/david/.conda/envs/xclim3.5/lib/python3.5/site-packages/rioxarray/__init__.py", line 8, in <module>
    import rioxarray.rioxarray  # noqa
  File "/home/david/.conda/envs/xclim3.5/lib/python3.5/site-packages/rioxarray/rioxarray.py", line 1104
    **profile_kwargs,
                    ^
SyntaxError: invalid syntax
>>> 

Expected Output

Output of rioxarray --version

rioxarray: command not found
@snowman2
Copy link
Member

snowman2 commented Nov 4, 2019

xarray has dropped support for python 3.5 here. As such, I don't think we will be able to support it moving forward.

@huard
Copy link
Author

huard commented Nov 4, 2019

Ok. Then I suggest updating setup.py to reflect that. Thanks for the quick response !

@snowman2
Copy link
Member

snowman2 commented Nov 4, 2019

I suggest updating setup.py to reflect that.

Agreed! Definitely needs to happen for clarity purposes.

@huard huard closed this as completed Nov 4, 2019
@snowman2
Copy link
Member

snowman2 commented Nov 4, 2019

09c3d78

@snowman2 snowman2 pinned this issue Nov 6, 2019
@snowman2 snowman2 unpinned this issue May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants