Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environments get overridden when cortex cluster up commands run in parallel #1410

Closed
vishalbollu opened this issue Sep 30, 2020 · 0 comments · Fixed by #1520
Closed

Environments get overridden when cortex cluster up commands run in parallel #1410

vishalbollu opened this issue Sep 30, 2020 · 0 comments · Fixed by #1520
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vishalbollu
Copy link
Contributor

vishalbollu commented Sep 30, 2020

Version

<= 0.20.0

Steps to reproduce

  1. run cortex cluster up --env cluster1
  2. while the cluster is spinning up open a new terminal and then run cortex cluster up --env cluster2
  3. After both clusters are created successfully, cortex env list

Expected behaviour

Depending on whichever cluster completed spinning up second, you will only find that only one of the environments was saved.

Suggested solution

Environments are cached after being read for the first time. When an environment is added or updated, the cached version modified and then written to disk. It is possible for the cached version to be out of sync with the actual environments file, especially for long running commands such as cortex cluster up. Refresh the cache before updating the environments file or get rid of the caching entirely.

@vishalbollu vishalbollu added the bug Something isn't working label Sep 30, 2020
@deliahu deliahu self-assigned this Oct 31, 2020
@deliahu deliahu added the v0.22 label Oct 31, 2020
@deliahu deliahu mentioned this issue Nov 2, 2020
2 tasks
@deliahu deliahu added this to the v0.23 milestone Nov 26, 2020
@deliahu deliahu added v0.22 and removed v0.23 labels Nov 26, 2020
@deliahu deliahu modified the milestones: v0.23, v0.22 Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants