Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory allocations in batch.newMergeIterator #2046

Closed
cyriltovena opened this issue Jan 28, 2020 · 2 comments
Closed

Memory allocations in batch.newMergeIterator #2046

cyriltovena opened this issue Jan 28, 2020 · 2 comments

Comments

@cyriltovena
Copy link
Contributor

I was on-call today and some queries (very high cardinality) causes allocations and therefore GC rate to go crazy, we're running ab3e836

here is the snapshot of traces alloc space:

image

And a drilldown on the code

image

see gc over time the first peak was a new deployment,

image

I don't think something has been introduced recently but we should at least try to reuse memory in that function. For high cardinality it would help a lot.

@bboreham
Copy link
Contributor

Duplicate of #1195 ?

@cyriltovena
Copy link
Contributor Author

Very much related yes ! Feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants