Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric to track samples dropped in distributor by metric_relabel #3954

Closed
bboreham opened this issue Mar 15, 2021 · 8 comments · Fixed by #4503
Closed

Add a metric to track samples dropped in distributor by metric_relabel #3954

bboreham opened this issue Mar 15, 2021 · 8 comments · Fixed by #4503
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! type/feature type/observability To help know what is going on inside Cortex

Comments

@bboreham
Copy link
Contributor

If you have a metric_relabel_configs ... action: drop then those samples disappear from cortex_distributor_received_samples_total.

I'd like them to be counted in cortex_discarded_samples_total.

Relating to the feature added in #3329

@bboreham bboreham added type/feature type/observability To help know what is going on inside Cortex labels Mar 15, 2021
@stale
Copy link

stale bot commented Jun 14, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 14, 2021
@bboreham
Copy link
Contributor Author

Still relevant

@stale stale bot removed the stale label Jun 16, 2021
@stale
Copy link

stale bot commented Sep 15, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 15, 2021
@bboreham
Copy link
Contributor Author

Still relevant

@stale stale bot removed the stale label Sep 23, 2021
@bboreham bboreham added the good first issue These are great first issues. If you are looking for a place to start, start here! label Sep 23, 2021
@pedro-stanaka
Copy link
Contributor

I will try to resolve this one this week. Trying to get involved with the project here.

@pedro-stanaka
Copy link
Contributor

@bboreham I tried to solve this issue on #4503, would really appreciate the feedback there.

@stale
Copy link

stale bot commented Jan 2, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 2, 2022
@pedro-stanaka
Copy link
Contributor

Waiting for feedback on PR, should be able to merge soon.

@stale stale bot removed the stale label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! type/feature type/observability To help know what is going on inside Cortex
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants