Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the max chunks per query limit shared between ingesters and storage gateways #4255

Closed
treid314 opened this issue Jun 3, 2021 · 1 comment · Fixed by #4260
Closed

Comments

@treid314
Copy link
Contributor

treid314 commented Jun 3, 2021

Is your feature request related to a problem? Please describe.
The config option -querier.max-fetched-chunks-per-query counts and limits the number of chunks returned independently for the ingester and storage gateway for a query. While, -querier.max-fetched-series-per-query and -querier.max-fetched-chunk-bytes-per-query limits the sum of series and chunk bytes returned between the ingester and store gateways for a query.

Describe the solution you'd like
The proposed solution is to migrate the -querier.max-fetched-chunks-per-query limit to the new QueryLimiter to limit the number of chunks returned as a sum of chunks returned from the ingester and storage gateway.

Additional context
-querier.max-fetched-chunks-per-query was previously marked as experimental.

@pracucci
Copy link
Contributor

pracucci commented Jun 3, 2021

-querier.max-fetched-chunks-per-query was previously marked as experimental.

I just realised it wasn't marked as experimental:
https://cortexmetrics.io/docs/configuration/v1guarantees/

Since it was done after cutting 1.9, let me do right now so we can gain some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants