New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compactor out of order chunks shouldn't block compaction #4688

Closed

1 of 2 tasks

jmcarp opened this issue Mar 28, 2022 · 1 comment

Closed

1 of 2 tasks

Compactor out of order chunks shouldn't block compaction #4688

jmcarp opened this issue Mar 28, 2022 · 1 comment

Contributor

jmcarp commented Mar 28, 2022 •

edited

Loading

Describe the bug
When the compactor encounters out of order chunks, compaction fails, and subsequent blocks are never compacted.

To Reproduce
Cause an uncompacted block to become corrupted; not sure how to do this, but it seems to happen regularly.

Expected behavior
The compactor skips the corrupted block and continues.

Storage Engine

Blocks
Chunks

Additional Context
From slack, it sounds like this should be resolved by updating the vendored thanos to a more recent version: https://cloud-native.slack.com/archives/CCYDASBLP/p1648424067729539?thread_ts=1648051851.918499&cid=CCYDASBLP. Are there breaking changes in thanos that would complicate upgrading the dependency? I'd be happy to attempt a PR if it would be helpful.

Contributor Author

jmcarp commented Mar 28, 2022

Sorry, duplicate of #3569. Happy to help with the fix anyway.

jmcarp closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment