Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some auth.ts typing broken in prod #77

Open
cory2067 opened this issue Mar 19, 2022 · 0 comments
Open

Some auth.ts typing broken in prod #77

cory2067 opened this issue Mar 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@cory2067
Copy link
Owner

In auth.ts, in the logout route, the line req.logout() fails to compile because logout() is not a property of Request.
This error happened in prod, but I can't reproduce it in dev.

I ended up temporarily fixing it by overriding that type to any: 0b24a00
but we should try to fix the root cause

Passport is supposed to override express.Request by adding on the additional logout property, but it seems like that isn't working

@cory2067 cory2067 added the bug Something isn't working label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant