Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change to assertIsBroadcastTxSuccess was not listed in 0.27 changelog #1076

Closed
williamchong opened this issue Mar 7, 2022 · 3 comments

Comments

@williamchong
Copy link

the breaking change commit which renamed assertIsBroadcastTxSuccess in stargateclient:
5baf978

assertIsBroadcastTxSuccess is actually used in many of the stargate + cosmjs example, say
https://gist.github.com/webmaster128/8444d42a7eceeda2544c8a59fbd7e1d9#send-your-first-stargate-transaction-from-javascript

It would be nice to list this renaming of assertIsBroadcastTxSuccess to assertIsDeliverTxSuccess in change log to save people's troubleshooting time

@msteiner96
Copy link
Member

The change seems to be in 0.27.0's changelog:

cosmjs/CHANGELOG.md

Lines 40 to 41 in e098e76

- @cosmjs/stargate: Merge `DeliverTxFailure` and `DeliverTxSuccess` into a
single `DeliverTxResponse` ([#878], [#949]). Add `assertIsDeliverTxFailure`.

@williamchong
Copy link
Author

Would be nice if we mention that assertIsBroadcastTxSuccess was replaced, instead of using the word Add which does not hint any breaking change

@webmaster128
Copy link
Member

You are right. What is missing is the CHANGELOG entry for this PR #946, which came before the one listed in the CHANGELOG.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants