We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertIsBroadcastTxSuccess
the breaking change commit which renamed assertIsBroadcastTxSuccess in stargateclient: 5baf978
stargateclient
assertIsBroadcastTxSuccess is actually used in many of the stargate + cosmjs example, say https://gist.github.com/webmaster128/8444d42a7eceeda2544c8a59fbd7e1d9#send-your-first-stargate-transaction-from-javascript
It would be nice to list this renaming of assertIsBroadcastTxSuccess to assertIsDeliverTxSuccess in change log to save people's troubleshooting time
assertIsDeliverTxSuccess
The text was updated successfully, but these errors were encountered:
The change seems to be in 0.27.0's changelog:
cosmjs/CHANGELOG.md
Lines 40 to 41 in e098e76
Sorry, something went wrong.
Would be nice if we mention that assertIsBroadcastTxSuccess was replaced, instead of using the word Add which does not hint any breaking change
replaced
Add
You are right. What is missing is the CHANGELOG entry for this PR #946, which came before the one listed in the CHANGELOG.
Thanks
fcf01d4
No branches or pull requests
the breaking change commit which renamed
assertIsBroadcastTxSuccess
instargateclient
:5baf978
assertIsBroadcastTxSuccess
is actually used in many of the stargate + cosmjs example, sayhttps://gist.github.com/webmaster128/8444d42a7eceeda2544c8a59fbd7e1d9#send-your-first-stargate-transaction-from-javascript
It would be nice to list this renaming of
assertIsBroadcastTxSuccess
toassertIsDeliverTxSuccess
in change log to save people's troubleshooting timeThe text was updated successfully, but these errors were encountered: