-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out how to use proto.Any registry #393
Comments
@webmaster128 I believe this is already done. Is there anything else that's needed for this issue? |
@willclarktech Simon is off today. If you link me to the usage of the code, I can confirm if it is done or ask any follow up questions. This is about parsing something that comes wrapped in Any - allowing us to no longer hard-code BaseAccount when parsing the proto.Any that stores an account. You can link me to that parse code and I can give feedback there. |
Ah, I see the #354 issue on the above. I would not close this issue until that works with a general solution. |
Interesting. So, this allows us to use a registry to explicitly encode some fields with an any type (to proto.Any) and later decode that proto.Any into the original type: https://github.com/cosmos/cosmjs/blob/master/packages/proto-signing/src/magic.spec.ts#L62-L70 So the |
I think we can close this as well. Thanks for linking me the solution |
@ethanfrey Yep! |
See cosmos/cosmos-sdk#6722
We need to:
The text was updated successfully, but these errors were encountered: