staking: bump all commission rate below param

[tac0turtle]

Summary

When a minimum commission rate is set via governance it should update all validators to be at this minimum.

This is a follow up to #10529.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[Terra854]

Are there any plans for what to do with validators whose max commission is below a given MinCommission?

[aaronc]

This depends on #9438. We should probably have an option that governance sets as to whether to grandfather commissions below the minimum commission or to set them to the minimum.

[Terra854]

I would prefer to not allow grandfathering of commissions as this will allow already created nodes to bypass the minimum commission values

[Terra854]

Any updates on this? It would be great if we can get this implemented by 0.45

[tac0turtle]

This will be included in 0.46 but not 0.45 which is slated for early January.

[sunnya97]

@Terra854 the reason for grandfathering existing validators is a technical one, in that there are currently no hooks for when a param is updated. The staking module does not know when the param is updated. The method for how to add hooks to the params module is up for debate, and I think the blocker here

Maybe one funny temporary solution we could do is just add a msg type called "RefreshCommissionRates" which after the MinCommissionRate is updated via governance, anyone can call to iterate over validators and update them to the new minimum commission rate.

Manual human hooks 😄

[iramiller]

Just writing this idea down so it gets out there somewhere...

The commission floor targets the idea of a single validator forcing a race to the bottom on fees. A related issue is the overall distribution of voting power across all validators (the top n of validators controlling a minor or super majority of stake).

A potentially more flexible solution that targets this distribution would be a curve function for the commission floor that ramps to 100% as the validator power approaches 33% of the total power in the network. This power adjustment would be added to the commission rate the validator has selected (of course not to exceed 100%). This adjustment function could apply when there is a change in voting power (end block style?). An additional consideration would be if this enforced floor was paid into the community pool instead of to the validator.

The above idea extends far outside the scope of this issue... but perhaps is still worth consideration separately by those that need the commission floor fix.

[Terra854]

Just writing this idea down so it gets out there somewhere...

The commission floor targets the idea of a single validator forcing a race to the bottom on fees. A related issue is the overall distribution of voting power across all validators (the top n of validators controlling a minor or super majority of stake).

A potentially more flexible solution that targets this distribution would be a curve function for the commission floor that ramps to 100% as the validator power approaches 33% of the total power in the network. This power adjustment would be added to the commission rate the validator has selected (of course not to exceed 100%). This adjustment function could apply when there is a change in voting power (end block style?). An additional consideration would be if this enforced floor was paid into the community pool instead of to the validator.

The above idea extends far outside the scope of this issue... but perhaps is still worth consideration separately by those that need the commission floor fix.

You might want to raise a feature request regarding this cause this sounds like you are proposing a totally different feature from what is proposed here

[Terra854]

Just want to check, is this still being worked on?

[alexanderbez]

This is honestly an application concern, not the SDK. Your upgrade handler should update validator commissions.

[Terra854]

This is honestly an application concern, not the SDK. Your upgrade handler should update validator commissions.

Ideally the parameter check should be run everytime the minimum commission parameter gets updated via governance, not just when we upgrade.

[tac0turtle]

Ideally the parameter check should be run everytime the minimum commission parameter gets updated via governance, not just when we upgrade.

this part can be done, we can make it part of the next staking module release

[alexanderbez]

In order to use param checking/validation in a stateful manner, you have to use the new method of parameters (i.e. not use x/params), which isn't released yet. So there isn't a way to do this in 0.45.x AFAIK. Correct me if I'm wrong @marbar3778

[tac0turtle]

we could do this now since it has been migrated. Lets make sure to include this in out staking refactor coming up soon

[alexanderbez]

@tac0turtle how shall we ensure this and others like it are tracked properly? Should we create board for each module refactor and add the issue to those board(s)?