Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context plumbing to remove TODO contexts #10558

Closed
4 tasks
creachadair opened this issue Nov 16, 2021 · 1 comment
Closed
4 tasks

Update context plumbing to remove TODO contexts #10558

creachadair opened this issue Nov 16, 2021 · 1 comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@creachadair
Copy link
Contributor

For background, see #10210 (comment)

In some places, the code uses context.TODO() to call APIs that accept context.Context values where a context is not available from the surrounding code.

Update these cases to plumb a context upward through the API.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@creachadair creachadair mentioned this issue Nov 16, 2021
Merged
19 tasks
@tac0turtle tac0turtle added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jan 17, 2022
@tac0turtle tac0turtle moved this from Icebox to Backlog in Cosmos SDK Maintenance Mar 11, 2022
@tac0turtle
Copy link
Member

since 0.35 was removed we don't have context.TODO()'s anymore

Repository owner moved this from Backlog to Done in Cosmos SDK Maintenance Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
No open projects
Cosmos SDK Maintenance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@creachadair @tac0turtle