Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #10515 to v0.44 #10862

Closed
4 tasks
karzak opened this issue Jan 3, 2022 · 5 comments
Closed
4 tasks

Backport #10515 to v0.44 #10862

karzak opened this issue Jan 3, 2022 · 5 comments

Comments

@karzak
Copy link
Contributor

karzak commented Jan 3, 2022

Summary of Bug

Using v0.44.5, I cannot currently migrate multisig threshold accounts from v0.39 to v0.44 - this is because #10515 has not been backported.

Version

v0.44.5

Steps to Reproduce

On v0.44.5, add a line after

require.Equal(t, uint32(3), lpk.Threshold)

require.Equal(t, 5, len(pk.(*kmultisig.LegacyAminoPubKey).PubKeys))

The test will fail, because the PubKeys field is being lost.

To apply the backport, you need to cherry-pick both 1662e45 and 3d3bc7c


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@karzak karzak changed the title Backport https://github.com/cosmos/cosmos-sdk/pull/10515 to v0.44 Backport #10515 to v0.44 Jan 3, 2022
@amaury1093
Copy link
Contributor

Ah yes, see #10871

@karzak
Copy link
Contributor Author

karzak commented Jan 13, 2022

@AmauryM any chance you can cut a v0.44.6 release this week? We are going to be upgrading the Kava blockchain shortly from v0.39 to v0.44 and ideally would like to pin to v0.44.6 rather than a commit hash.

@amaury1093
Copy link
Contributor

Sure, we can do that tomororw

@amaury1093
Copy link
Contributor

amaury1093 commented Jan 14, 2022

@karzak Probably today will be hard. Is Monday okay for a release? I started the release here: #10953, let's continue conversation there to not pollute this issue

@tac0turtle
Copy link
Member

0.44.6 is cut with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants