-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposer address to governance proposal #10932
Comments
This makes sense. Additionally, the proposer does matter: I take a proposal from someone I know much more seriously than one from a throwaway wallet loaded with only enough to make a deposit. |
Is there any update on this? I think it would be very useful. |
There is no open PR. But the work is trivial, but it is state machine breaking. So we need to decide if we want this in the next release (v0.47). cc @marbar3778 |
done and back ported to 0.47 |
Summary
When we first created the x/gov module, we chose to purposefully not store the proposer in a governance proposal under this high-minded idealism that "when evaluating a governance proposal, the proposer should not matter, only the content".
However, in practice, we've seen that basically every single block explorer has chosen to prominently display the proposer, fetching it from the tx data of the proposal. Given that this is the case, we might as well include the proposer into the proposal struct, so that its easier to fetch this data and integrate with.
For Admin Use
The text was updated successfully, but these errors were encountered: