Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs when an on-fly migration is performing #11048

Closed
4 of 6 tasks
robert-zaremba opened this issue Jan 27, 2022 · 9 comments
Closed
4 of 6 tasks

Add logs when an on-fly migration is performing #11048

robert-zaremba opened this issue Jan 27, 2022 · 9 comments
Assignees
Labels
C:Cosmovisor Issues and PR related to Cosmovisor C:x/upgrade

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Jan 27, 2022

Summary

Migration can take a long time, and we don't have much feedback

Goals

  • Add log whenever we start a new module migration
  • Add more cosmovisor logs

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added C:x/upgrade C:Cosmovisor Issues and PR related to Cosmovisor labels Jan 27, 2022
@alexanderbez
Copy link
Contributor

I think @ValarDragon created a similar issue and even addressed it? Not sure. I would try to dig it up.

@ValarDragon
Copy link
Contributor

I wrote these commits to fix the problems for Osmosis in our v5 upgrade: osmosis-labs@26abd7f osmosis-labs@f421dcb

^- I think those should be integrated into the mainline SDK

I had written this issue before for the cosmovisor side: #9672

@yaruwangway
Copy link
Contributor

cool! @ValarDragon please integrate to mainline.
thank you!

@ValarDragon
Copy link
Contributor

ValarDragon commented Jan 28, 2022

Do you have capacity to upstream them @yaruwangway ? I'd vastly prefer that.

I've found that upstreaming small commits on average takes 9x more of my time than writing the update in checking in for review, small nits, updating changelogs as we wait for it to get merged post-everyone-approving etc.

@yaruwangway
Copy link
Contributor

hi @ValarDragon , ok, I can do it ! I actually need these logs for gaia next upgrade which depends on sdk0.45, I might either need to make a branch based off sdk 0.45 with logs or ask sdk do a backport with these logs.

@ValarDragon
Copy link
Contributor

Awesome thanks! You should be able to backport the change to SDK v0.45, it doesn't break anything, and validators (and myself) really appreciated these logs during the Osmosis upgrade to v0.44

@yaruwangway
Copy link
Contributor

it seems someone already added the log

@yaruwangway
Copy link
Contributor

Hi @robert-zaremba , the migration logs are already added in sdk 0.46-alpha, shall we do a backport release of 0.45.1 with adding logs ? because next gaia release is likely to use sdk 0.45, I can make a pr and test the logs with gaia before the backport release.

@robert-zaremba
Copy link
Collaborator Author

Yes, I will add a backport. We want to release tomorrow 0.45.1, so let's merge

Repository owner moved this from Todo to Done in Cosmos SDK Maintenance Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor C:x/upgrade
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants