-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs when an on-fly migration is performing #11048
Comments
I think @ValarDragon created a similar issue and even addressed it? Not sure. I would try to dig it up. |
I wrote these commits to fix the problems for Osmosis in our v5 upgrade: osmosis-labs@26abd7f osmosis-labs@f421dcb ^- I think those should be integrated into the mainline SDK I had written this issue before for the cosmovisor side: #9672 |
cool! @ValarDragon please integrate to mainline. |
Do you have capacity to upstream them @yaruwangway ? I'd vastly prefer that. I've found that upstreaming small commits on average takes 9x more of my time than writing the update in checking in for review, small nits, updating changelogs as we wait for it to get merged post-everyone-approving etc. |
hi @ValarDragon , ok, I can do it ! I actually need these logs for gaia next upgrade which depends on sdk0.45, I might either need to make a branch based off sdk 0.45 with logs or ask sdk do a backport with these logs. |
Awesome thanks! You should be able to backport the change to SDK v0.45, it doesn't break anything, and validators (and myself) really appreciated these logs during the Osmosis upgrade to v0.44 |
it seems someone already added the log |
Hi @robert-zaremba , the migration logs are already added in sdk 0.46-alpha, shall we do a backport release of 0.45.1 with adding logs ? because next gaia release is likely to use sdk 0.45, I can make a pr and test the logs with gaia before the backport release. |
Yes, I will add a backport. We want to release tomorrow 0.45.1, so let's merge |
Summary
Migration can take a long time, and we don't have much feedback
Goals
For Admin Use
The text was updated successfully, but these errors were encountered: