Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: TestNewAnyWithCustomTypeURLWithErrorNoAllocation flakey race test failure #11664

Closed
alexanderbez opened this issue Apr 17, 2022 · 5 comments · Fixed by #11715
Closed

tests: TestNewAnyWithCustomTypeURLWithErrorNoAllocation flakey race test failure #11664

alexanderbez opened this issue Apr 17, 2022 · 5 comments · Fixed by #11715
Assignees
@julienrbrt
Labels
C:Encoding T: Tests

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Apr 17, 2022 •
edited
Loading

I've noticed the TestNewAnyWithCustomTypeURLWithErrorNoAllocation (race) test fail pretty frequently in CI. We need to investigate and fix.

Test output: https://pastebin.com/rW5UnK0Q

ref: https://github.com/cosmos/cosmos-sdk/runs/6053424807?check_suite_focus=true
@alexanderbez
Copy link
Contributor Author

@julienrbrt any chance you have a chance and/or interest in taking a stab at this?

@julienrbrt
Copy link
Member

Sure!

@julienrbrt julienrbrt self-assigned this Apr 17, 2022
@julienrbrt julienrbrt mentioned this issue Apr 21, 2022
Merged
19 tasks
@julienrbrt julienrbrt linked a pull request Apr 21, 2022 that will close this issue
test: fix TestNewAnyWithCustomTypeURLWithErrorNoAllocation test failure #11715
Merged
19 tasks
@julienrbrt julienrbrt moved this to In Review in Cosmos SDK Maintenance Apr 21, 2022
@julienrbrt julienrbrt assigned blushi and unassigned blushi Apr 21, 2022
Repository owner moved this from In Review to Done in Cosmos SDK Maintenance Apr 21, 2022
@julienrbrt
Copy link
Member

julienrbrt commented Apr 21, 2022 •
edited
Loading

Re-opening as my fix did not work 😢 : ref https://github.com/cosmos/cosmos-sdk/runs/6116723245?check_suite_focus=true

@julienrbrt julienrbrt reopened this Apr 21, 2022
@alexanderbez
Copy link
Contributor Author

☠️ I wonder what the issue could be...

@julienrbrt
Copy link
Member

Closing this in favor of #9010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
C:Encoding T: Tests
Projects
No open projects
Cosmos SDK Maintenance
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix TestNewAnyWithCustomTypeURLWithErrorNoAllocation test failure cosmos/cosmos-sdk
3 participants
@blushi @alexanderbez @julienrbrt